Fix reset (shutdown pin) - configuring as output pin mode#67
Closed
rickwargo wants to merge 7 commits intoadafruit:masterfrom
Closed
Fix reset (shutdown pin) - configuring as output pin mode#67rickwargo wants to merge 7 commits intoadafruit:masterfrom
rickwargo wants to merge 7 commits intoadafruit:masterfrom
Conversation
On my ESP32 WROOM DevKit v1, the initial HW Reset does not work, and if the device has a non-default id (e.g. 0x30), startup fails (actually after 25 seconds it may work as the chip gets reset). Had to watch this on my scope to figure out what was not working.
Changing typos to initiate another CI process as the earlier CI failed for unknown reasons.
The state variable was types as a byte - the fix required renaming the variable as it conflicted with the type. Also changed ordering of ISR routine to "declare" it before referencing it. Kept changes to a bare minimum as not to alter the intended functionality of the original example.
… variable and used accordingly
Author
|
In an attempt to resolve the CI error(s), I resolved a number of typing issues with (mostly around VL53L0X_Error) to clean it up, thinking that maybe it was being rejected due to that. I was wrong. Turns out some of the already committed files needed to be re-formatted with clang-format for the CI to succeed. There are also typos that are fixed. I have created another much simpler PR to resolve my initial intention (correct the HW reset problem). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my ESP32 WROOM DevKit v1, the initial HW Reset does not work, and if the device has a non-default id (e.g. 0x30), startup fails (actually after 25 seconds it may work as the chip gets reset). Had to watch this on my scope to figure out what was not working.
This gets resolved in setup() with a simple setting of the shutdown pin to output using pinMode.
Note, other examples that try to reset the sensor correctly set the output pin mode of the shutdown pin.