Skip to content

Conversation

tyeth
Copy link
Member

@tyeth tyeth commented Feb 19, 2025

No description provided.

@tyeth tyeth marked this pull request as ready for review February 19, 2025 14:47
@brentru brentru self-requested a review February 19, 2025 19:17
@brentru
Copy link
Member

brentru commented Feb 19, 2025

@tyeth This was marked ready for review but I was not assigned, do you want me to take a look at it?

}

protected:
Adafruit_LPS28 *_lps28; ///< LPS28DFW object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may want to set to nullptr

@tyeth
Copy link
Member Author

tyeth commented Feb 19, 2025

@tyeth This was marked ready for review but I was not assigned, do you want me to take a look at it?

Thanks for taking a look!

param mode true for FS_MODE=1 (1/2048 hPa/LSB), false for FS_MODE=0 (1/4096 hPa/LSB)
@brentru
Copy link
Member

brentru commented Feb 21, 2025

LGTM once you are ready

@tyeth
Copy link
Member Author

tyeth commented Feb 27, 2025

Will be closed by #702

@tyeth tyeth merged commit d79457f into main Mar 5, 2025
36 checks passed
@tyeth tyeth deleted the add-lps28 branch March 5, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants