Skip to content

Conversation

tyeth
Copy link
Member

@tyeth tyeth commented May 13, 2025

This merges the two open PRs (closes #744 #743), along with the Missing Drivers PR (closes #739).
Removes tinyUSB CDC port, adds reattach code to haltErrorV2 with optional reattach argument (default true).
Additionally adds some auto-detection addresses and default sensor type fixes.
Changes default SD CS pin for Pico 1/2/W to 17 to match PiCowbell Adalogger, logs CS pin on SD failure.

Copy link

github-actions bot commented May 13, 2025

Test Results

6 tests  ±0   6 ✅ ±0   50s ⏱️ +10s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1b4b617. ± Comparison against base commit 5564777.

♻️ This comment has been updated with latest results.

@brentru brentru self-requested a review May 13, 2025 14:01
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth This is a large PR. Overall it looks good. Requesting the following changes.

@tyeth tyeth requested a review from brentru May 13, 2025 15:30
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please merge when passing and cut a new offline release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants