Skip to content

Fix LEDC PWM DutyCycle #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

Fix LEDC PWM DutyCycle #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab82347
Attempt to fix the AnalogWrite issue
brentru May 21, 2025
486422c
Fix build error
brentru May 21, 2025
bb0d406
Clang-format PWM fix
tyeth May 23, 2025
564191c
Bump version to 1.0.0-beta.101
tyeth May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=Adafruit WipperSnapper
version=1.0.0-beta.100
version=1.0.0-beta.101
author=Adafruit
maintainer=Adafruit <[email protected]>
sentence=Arduino application for Adafruit.io WipperSnapper
Expand Down
2 changes: 1 addition & 1 deletion src/Wippersnapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
#endif

#define WS_VERSION \
"1.0.0-beta.100" ///< WipperSnapper app. version (semver-formatted)
"1.0.0-beta.101" ///< WipperSnapper app. version (semver-formatted)

// Reserved Adafruit IO MQTT topics
#define TOPIC_IO_THROTTLE "/throttle" ///< Adafruit IO Throttle MQTT Topic
Expand Down
3 changes: 2 additions & 1 deletion src/components/ledc/ws_ledc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ bool ws_ledc::analogWrite(uint8_t pin, int value) {

// Calculate duty cycle for the `value` passed in
// (assumes 12-bit resolution, 2^12)
uint32_t dutyCycle = (4095 / 255) * min(value, 255);
uint32_t dutyCycle =
(uint32_t)(((double)4095 / 255.0) * min((uint32_t)value, (uint32_t)255));

// Call duty cycle write
return setDuty(pin, dutyCycle);
Expand Down
Loading