Skip to content

Patch - \r handling for I2C Displays #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 18, 2025
Merged

Patch - \r handling for I2C Displays #759

merged 7 commits into from
Jun 18, 2025

Conversation

brentru
Copy link
Member

@brentru brentru commented Jun 17, 2025

No description provided.

@brentru brentru requested a review from tyeth June 17, 2025 16:22
tyeth
tyeth approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyeth tyeth self-requested a review June 17, 2025 16:56
tyeth
tyeth requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@tyeth tyeth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do a replace on char(13) too, the actual newline character if received.

@brentru brentru marked this pull request as ready for review June 17, 2025 19:43
tyeth
tyeth requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the SSD OLEDs to support the \r being printed as '\' then 'r' if not followed by \n

@brentru brentru merged commit 13d4ca9 into main Jun 18, 2025
40 checks passed
@brentru brentru deleted the fix-i2c-display-cr branch June 18, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyeth tyeth tyeth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @tyeth