Mlx90632 #799
Merged
Mlx90632 #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
commented
Aug 21, 2025
src/components/i2c/drivers/WipperSnapper_I2C_Driver_MLX90632D.h
Outdated
Show resolved
Hide resolved
|
I have the MLX90632 but won't be able to get to this until tomorrow or Monday. Did you try black-box testing the MLX90632 against its library in Arduino? Did you experience the same intermittent crashing during initialization? |
|
Had planned to but didn't for some reason (distracted or not wanting to consume more time on the issue). |
Okay, let's hold this PR until that issue is resolved and the a library version is released. |
|
@tyeth A new library version has been released, is this ready to be merged in now? I need it for a project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brentru this one has had weird intermittent crashes at init, with no output after "attempting to initialise MLX".
The device does come online and report data fine.
Testing removing and re-adding the device it would often crash and reset (but come back as online and added).
I took a bit of time to debug, mainly getting my setup going again, and it seems to be crashing in the begin of the MLX driver, where it checks
if (i2c_dev)it returns true on first run once when i watched it, and then randelete i2c_devand crashed.Adding the
i2c_dev = nullptrto the constructor resolved that. I've not done extensive testing since as didn't want to use more time on it. If you wouldn't mind checking the situation out (have you got the MLX90632?) it would be much appreciated.Originally I was going to ask why my MLX destructor doesn't get called, but it seems the
delete itercall has been removed for a few years now (git blame said 3yrs ago), as I thought it was my new driver failing to clear up after itself. I also wondered about the calling i2c begin again in the mlx driver, but that's okay to do now iirc.==========================================
The PR adds the MLX90632, which comes in a few flavours (-Bxy standard / Dxy medical, plus FoV etc), and the medical one adafruit have released first is the -Dxy variant which can be configured for extended range or medical range. I've therefore added two components for the -D variant, one for medical range and one for extended range.
It made sense to also add the -B variant (one extra component) which just uses standard range.
See related component PR adafruit/Wippersnapper_Components#278