Skip to content

Add me25ls01 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add me25ls01 #356

wants to merge 2 commits into from

Conversation

Styne13
Copy link

@Styne13 Styne13 commented Jun 2, 2025

Description of Change

  • add me25ls01 module support
  • add python requirements.txt to use with pip and venv

Styne13 added 2 commits June 2, 2025 17:47
Signed-off-by: Marcel <[email protected]>
To use e.g. with python venv and pip install -r requirements.txt

Signed-off-by: Marcel <[email protected]>
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR, please check review comment

//--------------------------------------------------------------------+
// USB
//--------------------------------------------------------------------+
#define USB_DESC_VID 0x1209
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you tell me where do you got the vid/pid for the board

Copy link
Author

@Styne13 Styne13 Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know 0x1209 is a generic vendor ID also used by other devices in this repo. For the product ID I orientate also another board here as a reference and counted one up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot pick a random vid/pid. 0x1209 is allocated by pid.codes. Please try to apply for an pid from that. Check out the git history/pr, I think there is a detail on how to do so. I will mark this PR as draft, feel free to re-mark it as ready when you got and update vid/pid

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you for the information.
I will do so and come back to you.

@hathach hathach marked this pull request as draft July 14, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants