-
Notifications
You must be signed in to change notification settings - Fork 489
Add me25ls01 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add me25ls01 #356
Conversation
Signed-off-by: Marcel <[email protected]>
To use e.g. with python venv and pip install -r requirements.txt Signed-off-by: Marcel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR, please check review comment
//--------------------------------------------------------------------+ | ||
// USB | ||
//--------------------------------------------------------------------+ | ||
#define USB_DESC_VID 0x1209 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you tell me where do you got the vid/pid for the board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know 0x1209 is a generic vendor ID also used by other devices in this repo. For the product ID I orientate also another board here as a reference and counted one up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot pick a random vid/pid. 0x1209 is allocated by pid.codes. Please try to apply for an pid from that. Check out the git history/pr, I think there is a detail on how to do so. I will mark this PR as draft, feel free to re-mark it as ready when you got and update vid/pid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you for the information.
I will do so and come back to you.
Description of Change