Skip to content

Conversation

relic-se
Copy link
Contributor

@relic-se relic-se commented Aug 5, 2025

When using a USB mouse to left click a menu item, you are restricted to only selecting items on the first page. For instance, if you are on page 2/2 and select "Match3", the program "Breakout" would instead load. This PR fixes this issue by including cur_page in the index calculation.

I've also improved the use of grid width and height configuration values to avoid arbitrary constants and allow the use of custom grid sizes (although thumbnails don't scale to grid size).

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I confirmed the mouse click issue and fix.

A little configurability is nice as well. The icons won't scale, but theoretically someone could use all their own apps and decide to use icons smaller than we did so that they can fit more on the screen at once.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve again after merged main

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Aug 5, 2025

It won't let me merge this, and I'm not entirely sure why. I heard Github PRs had some sort of technical issue today, perhaps this is related to that. I'll check back after a while. If it's still not working I may try to make a new PR from the same branch.

@relic-se
Copy link
Contributor Author

relic-se commented Aug 5, 2025

It won't let me merge this, and I'm not entirely sure why. I heard Github PRs had some sort of technical issue today, perhaps this is related to that. I'll check back after a while. If it's still not working I may try to make a new PR from the same branch.

I don't see anything wrong on my end either. PRs were down for me earlier today as well (HTTP 500).

@relic-se relic-se marked this pull request as draft August 5, 2025 18:46
@relic-se relic-se marked this pull request as ready for review August 5, 2025 18:46
@FoamyGuy FoamyGuy merged commit 631d270 into adafruit:main Aug 5, 2025
1 check passed
@relic-se relic-se deleted the mouse-click-index branch August 5, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants