Update magic_schema.json to have complete visualization object#208
Merged
lorennorman merged 3 commits intomainfrom Aug 11, 2025
Merged
Update magic_schema.json to have complete visualization object#208lorennorman merged 3 commits intomainfrom
lorennorman merged 3 commits intomainfrom
Conversation
Member
Author
|
After discussion I now see that type is not required for magic config, but is for component repo. |
lorennorman
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates magic board schema to include full visualisation object from components repo.
https://github.com/adafruit/Wippersnapper_Components/blob/1f7823e15ee49acffb15aab2cc947ea7d1ad6619/components/pin/schema.json#L84-L111
Slightly concerned that the exported did not include the visualisation.type which is in theory mandatory. The magic config import also worked fine without it.
Wippersnapper_Boards/boards/magtag/magic.json
Lines 76 to 80 in 5ee7dc9