Add New Display Component Type #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@tyeth Could you review this before I pass it to Loren? Thanks! |
tyeth
requested changes
Aug 22, 2025
Member
|
It felt like either YAGNI or use it, and then later let the firmware add
support for colour/greyscale to displays at which point it will "just
work", and for now the firmware treats grayscale as mono in the driver code.
I had not appreciated at the time of writing the comment the incredible
slowness of grayscale refreshing. Maybe we'll have to have two definitions
for the magtag display to select between mono + grayscale.
…On Fri, 22 Aug 2025 at 18:11, Brent Rubell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In components/display/magtag/definition.json
<#277 (comment)>
:
> @@ -0,0 +1,17 @@
+{
+ "displayName": "MagTag E-Ink Display",
+ "vendor": "Adafruit",
+ "productURL": "https://www.adafruit.com/product/4800",
+ "documentationURL": "https://learn.adafruit.com/adafruit-magtag",
+ "published": false,
+ "description": "A 2.9\" black and white e-ink display onboard the Adafruit MagTag",
+ "displayType": {
+ "type": "epd",
+ "spiEpd": {
+ "bus": 0
+ },
+ "epdConfig": {
+ "mode": "mono"
It's capable of it but the code doesn't support greyscale colors - it's
faster to render text in mono and default to that (15s vs 1-2s with mono).
—
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ45YDHKCFN3K5D2W5DT3O5FNPAVCNFSM6AAAAACEPMBTMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNBVGIZDANRQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Author
|
I think instead of 2 definitions, we'll expose |
Member
|
Nice, like it!
…On Fri, 22 Aug 2025, 18:21 Brent Rubell, ***@***.***> wrote:
*brentru* left a comment (adafruit/Wippersnapper_Components#277)
<#277 (comment)>
I think instead of 2 definitions, we'll expose mode in the Configure
Component selector. The user can decide and that field is dynamic.
—
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ43GNNNYNNMNU3Q3DPT3O5GRXAVCNFSM6AAAAACEPMBTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJVGA3TIOJSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Author
|
I have extended the Display component JSON Schema for compatibility with TFT displays and added the following definitions:
|
tyeth
reviewed
Aug 27, 2025
Member
|
I'm confused, is it actually a panel thats portrait? The class docs
<https://adafruit.github.io/Adafruit-ST7735-Library/html/class_adafruit___s_t7789.html#a2dbb8298fe4309ffc41873a49fca3a3f>
show the init call takes width then height. In a similar situation for the
SH1107 i2c featherwing I've kept width and height correct as the user
perspective / board spec (so the UI boxes work correctly too) and then had
to switch based on the component to passing the w/h args in reverse order
solely for that board.
…On Wed, 27 Aug 2025 at 15:21, Brent Rubell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In components/display/tft-esp32-s2-feather/definition.json
<#277 (comment)>
:
> + "width": 135,
+ "height": 240,
Yes it feels backwards but the initialization call for the display takes (width,
height) which is 240x135.
—
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ445IE22VXCT4LBYBT33PW5IBAVCNFSM6AAAAACEPMBTMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNRQGAYTQMJWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
lorennorman
reviewed
Sep 10, 2025
Contributor
|
|
Member
Author
|
@lorennorman do you still need me to sync it to this PR? |
Contributor
|
no i handled what i needed. this might come up again though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a new
displaycomponentSchema:
components/display/schema.json).EPD
components/display/magtag/definition.json).TFT
Adds the following definitions:
components/display/rev-tft-esp32-s2-feather/definition.json)components/display/rev-tft-esp32-s3-feather/definition.json)components/display/tft-esp32-s2-feather/definition.json)components/display/tft-esp32-s3-feather/definition.json)Actions have been updated to reflect this change.