Add MagTag generic display, update ILI0373 display#287
Merged
Conversation
Member
Author
|
@lorennorman Seems like the Validate action is failing due to a network issue? |
Contributor
|
This is great, @brentru. Re: the Action failing, yes it appears Re: using unspecified for
|
Contributor
|
Ooops I just re-read the json and see you added "unspecified" as the I will simply add an "Unspecified" option to the EPD mode input. |
lorennorman
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modeinepdConfigfrom"mono"to"grayscale4"for the 2.9" ILI0373 E-Ink display.components/display/eink-magtag/definition.jsonfor the Adafruit MagTag 2.9" E-Ink displayunspecifiedas defaults for thedriverandmodeconfiguration since the firmware should automatically detect the generic definition, perform detection for the display driver, and fill in the PB fields with the appropriate configuration. This felt like the simplest way to achieve this, I am open to other ideas, though.