Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates CI to support/require larger images, still in a 4:3 ratio, and offer compression site if needed.
Was part of ENS161 PR #296, but now broken out.
Rationale
The images are now used in more places than originally intended and so the 400x300 images can look poor on an ultra-wide display showing the new Works-with-WipperSnapper page.
The ideal solution is to have multiple image sizes stored per component, but until that is needed/actioned then this PR will encourage new components to have higher res images.
Before merge there needs to be this max-width fix applied to avoid ballooning the Edit/New component dialog:
https://github.com/AdafruitInternalDev/io-rails/pull/881