-
Notifications
You must be signed in to change notification settings - Fork 3
[v1] Support I2C Output Components #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lorennorman Please hold off reviewing this until I can provide you with details about how this is implemented. Thanks! |
@lorennorman This is ready for review. The only thing that I did not address is |
This decision also makes sense as ladyada mentioned she wants backlight LED control for the character LCD (LED backlight “feed” for character LCD disable/enable (0 and 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 looks great, will be perfect once the capitalizations are tweaked for consistency
@lorennorman I've addressed the review comment. Is it safe to merge this in, or should we leave this for here as this'll initially sit on staging? |
i think you can merge away! |
Will merge after SSD1306 is implemented and tested on hardware! |
adafruit/Adafruit_Wippersnapper_Arduino#751 looks good, merging this! |
Backport of commits within #133 for api-v1
Resolves: #143