Skip to content

Conversation

brentru
Copy link
Member

@brentru brentru commented May 14, 2025

Backport of commits within #133 for api-v1

Resolves: #143

@brentru
Copy link
Member Author

brentru commented May 15, 2025

@lorennorman Please hold off reviewing this until I can provide you with details about how this is implemented. Thanks!

@brentru brentru removed the request for review from lorennorman May 15, 2025 18:38
@brentru brentru requested a review from lorennorman May 16, 2025 17:45
@brentru
Copy link
Member Author

brentru commented May 16, 2025

@lorennorman This is ready for review.

The only thing that I did not address is I2CDeviceOutputWrite's output_msg field. I'm uncertain if future I2C output devices that we will support might require message types beyond strings, or if we'll need to include additional parameters with the message (such as delimiter options, font options, font size options, or backlight color settings).

@brentru
Copy link
Member Author

brentru commented May 16, 2025

This decision also makes sense as ladyada mentioned she wants backlight LED control for the character LCD (LED backlight “feed” for character LCD disable/enable (0 and 1))

Copy link
Contributor

@lorennorman lorennorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 looks great, will be perfect once the capitalizations are tweaked for consistency

@brentru
Copy link
Member Author

brentru commented May 19, 2025

@lorennorman I've addressed the review comment. Is it safe to merge this in, or should we leave this for here as this'll initially sit on staging?

@lorennorman
Copy link
Contributor

i think you can merge away!

@brentru
Copy link
Member Author

brentru commented May 19, 2025

Will merge after SSD1306 is implemented and tested on hardware!

@brentru
Copy link
Member Author

brentru commented May 20, 2025

adafruit/Adafruit_Wippersnapper_Arduino#751 looks good, merging this!

@brentru brentru merged commit e1d9201 into master May 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend I2C to allow I2C Output Components

2 participants