Update trinket_m0_haxpress.md #1506
Conversation
Links are now all dead links.
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
There is an archived version available here: https://web.archive.org/web/20210727135908/http://daveastels.com/trinket-m0-express-hack.html It's missing some of the original images, but it's got a lot of information for anyone who would want to create one of these.
I think it'd be good to link to that one and note it in the text as an archived version.
Changed link to archived version as suggested. Thanks.
|
Updated changes with new archived URL. Not sure if I did it right for the Board URL line though. |
Timeline8
left a comment
Timeline8
left a comment
There was a problem hiding this comment.
Updated links to use the archived version of the old web page no longer online.
_board/trinket_m0_haxpress.md
Outdated
| manufacturer: "Dave Astels" | ||
| board_url: | ||
| - "http://daveastels.com/trinket-m0-express-hack.html" | ||
| board_url: https://web.archive.org/web/20210727135908/http://daveastels.com/trinket-m0-express-hack.html |
There was a problem hiding this comment.
I think it's best to make formatting match all of the other device config files with the board URL on it's own line with a hyphen at the beginning.
- "https://web.archive.org/web/20210727135908/http://daveastels.com/trinket-m0-express-hack.html"
I'm not entirely certain if that syntax is 100% necessary, and I also don't know for sure where this board_url value gets used, but I think keeping it consistent across devices whenever possible is best.
Timeline8
left a comment
Timeline8
left a comment
There was a problem hiding this comment.
Agreed. Looks good to me.
Moved URL to next line with indented hyphen.
Didn't look the same as before. 2nd attempt to make it match.
Timeline8
left a comment
Timeline8
left a comment
There was a problem hiding this comment.
OK I think it looks good now.
2 participants
Links are now all dead links.