-
Notifications
You must be signed in to change notification settings - Fork 700
installation instructions button #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe it should be inverted / outline only like the open installer button? So that there is only a single solid purple filled one? |
|
Does the "Installation Instructions" link cover multiple possibilities? In that case maybe it shouldn't be a button like the others, but a link in the text above? Or, some distinct kind of button. Otherwise it looks like one of several similar choices. |
|
@dhalbert I'm not sure if I understand what you mean all the way about covering multiple possibilities. But I think yes if I am understanding. It will link to whatever value is in the board file's metadata for |
|
Thanks @johnnohj I like the 'installation instructions' button up above the download links. I'll tinker with it today and try to get it shifted up to there. |
I was thinking about some way of ensuring the (Edit: My assumption, of course, is that anyone there to download the |
|
The latest commit moves this button to up above the download buttons and next to the release notes link: It turns out that the width of the button originally was actually a tad larger than the width of the other download buttons in that column, which resulted in the arrow icon getting wrapped onto the next line down and looking weird. I reworded the button to use "INSTALL" instead of "INSTALLATION" to work around that. I also changed the link to open in a new tab. With regards to putting .UF2 above .BIN: As far as I can tell the order isn't specified anywhere currently. The order they appear in comes down to the order of their appearance in this list iteration: circuitpython-org/_includes/download/board.html Lines 134 to 136 in 59fe0d4
I haven't given it extensive thought, but I think I would be in favor of swapping the order of them if there is no reason that will cause trouble or break something else. I do think it could be a seperate issue / PR from this one since it's not tied to the install instructions |
|
How about "HOW TO INSTALL" as opposed to "INSTALL INSTRUCTIONS"? I too think the .UF2 should be first. |
|
"HOW TO INSTALL" fits nicely and I do think it's better than using "INSTRUCTIONS". The latest commit changes to that. I've created #1517 to track swapping the UF2 and BIN buttons. I think I have a relatively simple idea to implement it, if that works out I'll submit a seperate PR for it. |
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks @johnnohj for the suggestions.







Resolves: #1034
Make the
download_instructionsmetadata field valid for CircuitPython core in addition to Blinka. If it has a value add a button linking to it to the download page.I've only added the metadata to a single esp32 so far, but the rest of them could get updated to point to this guide if the way this has been added looks okay.