Skip to content

Fix modules extra comma and spacing #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix modules extra comma and spacing #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a284f5
fix comma spacing and extra comma at end of modules list
FoamyGuy Nov 4, 2024
5565a34
change features list style to match modules.
FoamyGuy Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions _includes/download/board.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,7 @@ <h3>CircuitPython {{ version.version }}</h3>
{% else %}
<a target="_blank" class="library-link" href="https://docs.circuitpython.org/en/latest/shared-bindings/{{ module_name }}">
{% endif %}
{{ module_name }}
</a>{% if module_name != version.modules[version.modules.size - 1] %}, {% endif %}
{{ module_name }}</a>{% unless forloop.last %}, {% endunless %}
{% endfor %}
</span>
</p>
Expand All @@ -172,17 +171,18 @@ <h3>CircuitPython {{ version.version }}</h3>
<span class="download-modules {% if version.stable %}stable{% else %}unstable{% endif %}">
{% for module_name in version.frozen_libraries %}
<a target="_blank" class="library-link" href="https://docs.circuitpython.org/projects/{{ module_name | split: 'adafruit_' | last }}">
{{ module_name }}
</a>{% if module_name != version.frozen_libraries[version.frozen_libraries.size - 1] %}, {% endif %}
{{ module_name }}</a>{% unless forloop.last %}, {% endunless %}
{% endfor %}
</span>
</p>
{% endif %}
{% if page.features %}
<p>Features:
{% for feature in page.features %}
<span class="feature-span">{{feature}}</span>
{% endfor %}
<span class="features-list">
{% for feature in page.features %}
<a class="library-link" href="/downloads?features={{ feature }}">{{feature}}</a>{% unless forloop.last %}, {% endunless %}
{% endfor %}
</span>
</p>
{% endif %}
</div>
Expand Down
14 changes: 2 additions & 12 deletions assets/sass/pages/_download.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
background-color: $purple;
}

.download-modules {
.download-modules, .features-list {
color: $purple;
}
}
Expand All @@ -135,7 +135,7 @@
a.download-button:hover, a.download-button-unrecommended:hover {
background-color: $purple;
}
.download-modules {
.download-modules, .features-list {
color: $purple;
}
}
Expand Down Expand Up @@ -184,16 +184,6 @@
}
}
}
.feature-span {
padding: 2px 4px 2px 4px;
margin-left: 3px;
margin-bottom: 3px;
display: inline-block;
background-color: $purple;
color: #fff;
border-radius: 5px;
font-size: 14px;
}
}

@media (max-width: $screen-lg) {
Expand Down