address review

dhalbert · dhalbert · commit 1e29c6a222bb · 2025-04-14T18:37:48.000-04:00
diff --git a/data/nvm.toml b/data/nvm.toml
@@ -1 +1 @@
-Subproject commit 6b678f15e378edce820f2ffdef3286b3e55449e7
+Subproject commit 8bca037b052a4a4dc46a56a25a1b802652ee3f47
diff --git a/ports/raspberrypi/common-hal/audiobusio/I2SOut.c b/ports/raspberrypi/common-hal/audiobusio/I2SOut.c
@@ -31,12 +31,12 @@ const uint16_t i2s_program[] = {
     mov x osr         side 0b11 ; Save the new value in case we need it again
     set y 14          side 0b11
 bitloop1:
-    out pins 1        side 0b10 [2]
+    out pins 1        side 0b10 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b00 [2]
     set y 14          side 0b01 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b01 [2]
     out pins 1        side 0b10 [2]
 */
@@ -67,12 +67,12 @@ const uint16_t i2s_program_left_justified[] = {
     mov x osr         side 0b01 ; Save the new value in case we need it again
     set y 14          side 0b01
 bitloop1:
-    out pins 1        side 0b10 [2]
+    out pins 1        side 0b10 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b10 [2]
     set y 14          side 0b11 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b01 [2]
     out pins 1        side 0b00 [2]
 */
@@ -103,12 +103,12 @@ const uint16_t i2s_program_swap[] = {
     mov x osr         side 0b11 ; Save the new value in case we need it again
     set y 14          side 0b11
 bitloop1:
-    out pins 1        side 0b01 [2]
+    out pins 1        side 0b01 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b00 [2]
     set y 14          side 0b10 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b10 [2]
     out pins 1        side 0b01 [2]
 */
@@ -140,12 +140,12 @@ const uint16_t i2s_program_left_justified_swap[] = {
     mov x osr         side 0b10 ; Save the new value in case we need it again
     set y 14          side 0b10
 bitloop1:
-    out pins 1        side 0b01 [2]
+    out pins 1        side 0b01 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b01 [2]
     set y 14          side 0b11 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b10 [2]
     out pins 1        side 0b00 [2]
 */
diff --git a/ports/raspberrypi/common-hal/audiobusio/i2s.pio b/ports/raspberrypi/common-hal/audiobusio/i2s.pio
@@ -15,11 +15,11 @@
     mov x osr         side 0b11 ; Save the new value in case we need it again
     set y 14          side 0b11
 bitloop1:
-    out pins 1        side 0b10 [2]
+    out pins 1        side 0b10 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b00 [2]
     set y 14          side 0b01 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b01 [2]
     out pins 1        side 0b10 [2]
diff --git a/ports/raspberrypi/common-hal/audiobusio/i2s_left.pio b/ports/raspberrypi/common-hal/audiobusio/i2s_left.pio
@@ -15,11 +15,11 @@
     mov x osr         side 0b01 ; Save the new value in case we need it again
     set y 14          side 0b01
 bitloop1:
-    out pins 1        side 0b10 [2]
+    out pins 1        side 0b10 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b10 [2]
     set y 14          side 0b11 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b01 [2]
     out pins 1        side 0b00 [2]
diff --git a/ports/raspberrypi/common-hal/audiobusio/i2s_swap.pio b/ports/raspberrypi/common-hal/audiobusio/i2s_swap.pio
@@ -15,11 +15,11 @@
     mov x osr         side 0b11 ; Save the new value in case we need it again
     set y 14          side 0b11
 bitloop1:
-    out pins 1        side 0b01 [2]
+    out pins 1        side 0b01 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b00 [2]
     set y 14          side 0b10 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b10 [2]
     out pins 1        side 0b01 [2]
diff --git a/ports/raspberrypi/common-hal/audiobusio/i2s_swap_left.pio b/ports/raspberrypi/common-hal/audiobusio/i2s_swap_left.pio
@@ -15,11 +15,11 @@
     mov x osr         side 0b10 ; Save the new value in case we need it again
     set y 14          side 0b10
 bitloop1:
-    out pins 1        side 0b01 [2]
+    out pins 1        side 0b01 [2] ; Right channel first
     jmp y-- bitloop1  side 0b11 [2]
     out pins 1        side 0b01 [2]
     set y 14          side 0b11 [2]
 bitloop0:
-    out pins 1        side 0b00 [2]
+    out pins 1        side 0b00 [2] ; Then left channel
     jmp y-- bitloop0  side 0b10 [2]
     out pins 1        side 0b00 [2]
