require specific ruff version #10035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Feb 7, 2025
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Makes sense , since pre-commit-config.yaml requires explicit versions.
tannewt
approved these changes
Feb 7, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thank you! I may have run into this too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble with pre-commit always finding files to change, because the ruff run during two different steps of pre-commit were different.
Installing the requirements with
pip install -r requirements-dev.txtdidn't resolve the problem, because the ruff version was not pinned. So, pin it now.