Disallow identical AudioOut channel pins. Work around ESP-IDF ESP32-S2 bug that swaps DAC channels randomly. #10182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 bug that swaps DAC channels randomly. - Fixes adafruit#10003. Stumbled on espressif/esp-idf#11425 bug while testing. It causes the left and right channels to be swapped randomly on play, which was very confusing. Worked around by forcing a deinit/init on each play. Also got confused because board.A0 and board.A1 are not consistently assigned to left/right channels. Added a documentation warning about this.
eightycc
approved these changes
Mar 26, 2025
Collaborator
eightycc
left a comment
eightycc
left a comment
There was a problem hiding this comment.
Looks fine. I don't have merge authority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled on espressif/esp-idf#11425 bug while testing. It causes the left and right channels to be swapped randomly on play, which was very confusing. Worked around by forcing a deinit/init on each play.
I also got confused because board.A0 and board.A1 are not consistently assigned to left/right channels. Added a documentation warning about this.
Shuffled code around a little in
ports/espressif/common-hal/audioio/AudioOut.cto allow calling internal routines instead of common_hal routines.Useful short test audio file: Spoken words "left channel", "right channel", "both channels":
left-right-longer-22050.wav.zip
FYI @MarshallMiller