Skip to content

Enable old-style-definition diagnostic on atmel-samd #10375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Enable old-style-definition diagnostic on atmel-samd #10375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ports/atmel-samd/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ else
endif
endif

CFLAGS += $(INC) -Wall -Werror -std=gnu11 -nostdlib -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) -Werror=missing-prototypes
CFLAGS += $(INC) -Wall -Werror -std=gnu11 -nostdlib -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) -Werror=missing-prototypes -Werror=old-style-definition

ifeq ($(CHIP_FAMILY), samd21)
CFLAGS += \
Expand Down
2 changes: 1 addition & 1 deletion ports/atmel-samd/audio_dma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ static audio_dma_t *audio_dma_state[AUDIO_DMA_CHANNEL_COUNT];
// This cannot be in audio_dma_state because it's volatile.
static volatile bool audio_dma_pending[AUDIO_DMA_CHANNEL_COUNT];

uint8_t find_sync_event_channel_raise() {
uint8_t find_sync_event_channel_raise(void) {
uint8_t event_channel = find_sync_event_channel();
if (event_channel >= EVSYS_SYNCH_NUM) {
mp_raise_RuntimeError(MP_ERROR_TEXT("All sync event channels in use"));
Expand Down
4 changes: 2 additions & 2 deletions ports/atmel-samd/common-hal/_pew/PewPew.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ void pewpew_interrupt_handler(uint8_t index) {
tc->COUNT16.INTFLAG.reg = TC_INTFLAG_MC0;
}

void pew_init() {
void pew_init(void) {
pew_obj_t *pew = MP_STATE_VM(pew_singleton);

common_hal_digitalio_digitalinout_switch_to_input(pew->buttons, PULL_UP);
Expand Down Expand Up @@ -105,6 +105,6 @@ void pew_reset(void) {
MP_STATE_VM(pew_singleton) = NULL;
}

uint16_t pew_get_ticks() {
uint16_t pew_get_ticks(void) {
return pewpew_ticks;
}
2 changes: 1 addition & 1 deletion ports/atmel-samd/common-hal/analogio/AnalogIn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void common_hal_analogio_analogin_deinit(analogio_analogin_obj_t *self) {
self->pin = NULL;
}

void analogin_reset() {
void analogin_reset(void) {
}

uint16_t common_hal_analogio_analogin_get_value(analogio_analogin_obj_t *self) {
Expand Down
2 changes: 1 addition & 1 deletion ports/atmel-samd/common-hal/touchio/TouchIn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void common_hal_touchio_touchin_deinit(touchio_touchin_obj_t *self) {
self->config.pin = NO_PIN;
}

void touchin_reset() {
void touchin_reset(void) {
Ptc *ptc = ((Ptc *)PTC);
if (ptc->CTRLA.bit.ENABLE == 1) {
ptc->CTRLA.bit.ENABLE = 0;
Expand Down