Skip to content

Fix radio union type hints #10602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhalbert merged 1 commit into from
Aug 31, 2025
Merged

Fix radio union type hints #10602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions shared-bindings/wifi/Radio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ MP_PROPERTY_GETSET(wifi_radio_enabled_obj,
(mp_obj_t)&wifi_radio_get_enabled_obj,
(mp_obj_t)&wifi_radio_set_enabled_obj);

//| hostname: Union[str | ReadableBuffer]
//| hostname: Union[str, ReadableBuffer]
//| """Hostname for wifi interface. When the hostname is altered after interface started/connected
//| the changes would only be reflected once the interface restarts/reconnects."""
static mp_obj_t wifi_radio_get_hostname(mp_obj_t self_in) {
Expand Down Expand Up @@ -325,8 +325,8 @@ MP_DEFINE_CONST_FUN_OBJ_1(wifi_radio_stop_station_obj, wifi_radio_stop_station);

//| def start_ap(
//| self,
//| ssid: Union[str | ReadableBuffer],
//| password: Union[str | ReadableBuffer] = b"",
//| ssid: Union[str, ReadableBuffer],
//| password: Union[str, ReadableBuffer] = b"",
//| *,
//| channel: int = 1,
//| authmode: Iterable[AuthMode] = (),
Expand Down Expand Up @@ -438,11 +438,11 @@ MP_PROPERTY_GETTER(wifi_radio_ap_active_obj,

//| def connect(
//| self,
//| ssid: Union[str | ReadableBuffer],
//| password: Union[str | ReadableBuffer] = b"",
//| ssid: Union[str, ReadableBuffer],
//| password: Union[str, ReadableBuffer] = b"",
//| *,
//| channel: int = 0,
//| bssid: Optional[Union[str | ReadableBuffer]] = None,
//| bssid: Optional[Union[str, ReadableBuffer]] = None,
//| timeout: Optional[float] = None,
//| ) -> None:
//| """Connects to the given ssid and waits for an ip address. Reconnections are handled
Expand Down