Add Waveshare ESP32S3 Touch LCD 2.8inch display board #10691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Oct 27, 2025
There was a problem hiding this comment.
Thank you for the PR! It looks like there are a couple minor formatting issues that can be fixed locally automatically if you install pre-commit. Instructions to do that are here: https://learn.adafruit.com/improve-your-code-with-pylint/check-your-code-with-pre-commit
|
Just ran pre-commit locally and fixed the two formatting issues. Please let me know if anything else needs updating. Thank you! |
tannewt
requested changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new board: Waveshare ESP32-S3 Touch LCD 2.8
Tested
qmi8658.pydriver (pin aliases OK)Not tested
PID
0x825F— Waveshare ESP32-S3-Touch-LCD-2.8 (CircuitPython/MicroPython) Permalink