Skip to content

improve _bleio.Connection.bind() doc, validation, and error messages #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

improve _bleio.Connection.bind() doc, validation, and error messages #9732

merged 1 commit into from
Oct 21, 2024

Conversation

@dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Oct 18, 2024

Changes:

  • Note in documentation that _bleio.Connection.pair(bond=False) is not implemented, and validate that bond == True.
  • Print a better message on espressif and nordic when trying to pair when pairing is already in progress. Right now it prints "unknown ..." and gives a numeric error code.

@dhalbert dhalbert requested review from jepler and tannewt October 19, 2024 00:29
tannewt
tannewt approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit c50c795 into adafruit:main Oct 21, 2024
562 checks passed
@dhalbert dhalbert deleted the pair-improvements branch October 23, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhalbert @tannewt