Skip to content

Throw TypeError when json-serializing invalid types #9789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Throw TypeError when json-serializing invalid types #9789

merged 1 commit into from
Nov 4, 2024

Conversation

@jepler
Copy link

@jepler jepler commented Nov 4, 2024

To do this without spending a lot of code, a new type flag is used for this.

This behavior is in line with standard Python.

Closes: #9768

@jepler
Throw TypeError when json-serializing invalid types
9113e17 
This behavior is in line with standard Python

Closes: adafruit#9768
dhalbert
dhalbert approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I had in mind from #9768, but I hadn't checked whether we had room. Thank you for doing this quickly!

@dhalbert dhalbert merged commit 973f597 into adafruit:main Nov 4, 2024
562 checks passed
@dhalbert dhalbert mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid output from json.dump/dumps with IPV4Address

2 participants

@jepler @dhalbert