Add new atmel-samd board - Bradán Lane STUDIO Coin M0 #9797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
reviewed
Nov 8, 2024
Collaborator
Since Scott is off for a few weeks, that won't get merged, but we can proceed on this anyway. |
Author
|
thanks for the head's up on the VID:PID status |
Author
|
Is there more I need to do before this new board is merged? |
dhalbert
requested changes
Nov 19, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I touched up some of the settings to remove redundancies. The details of this are in mpconfigport.mk
You can find out whether a certain option is set or not by doing:
make BOARD=yourboardname print-CIRCUITPY_WHATEVER
ports/atmel-samd/boards/bradanlanestudio_coin_m0/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
ports/atmel-samd/boards/bradanlanestudio_coin_m0/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
ports/atmel-samd/boards/bradanlanestudio_coin_m0/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
ports/atmel-samd/boards/bradanlanestudio_coin_m0/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
ports/atmel-samd/boards/bradanlanestudio_coin_m0/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
ports/atmel-samd/boards/bradanlanestudio_coin_m0/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Halbert <[email protected]>
Co-authored-by: Dan Halbert <[email protected]>
Co-authored-by: Dan Halbert <[email protected]>
Co-authored-by: Dan Halbert <[email protected]>
Co-authored-by: Dan Halbert <[email protected]>
Co-authored-by: Dan Halbert <[email protected]>
Collaborator
|
BTW, you can use Add Suggestion to Batch and then commit them all at once. |
dhalbert
approved these changes
Nov 19, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks for your perseverance on this PR.
Author
|
thank you for all the assistance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Coin M0 is a simple round SAMD21 board with sound, touch pads, and LEDs.
A popular use is to create small purpose-built touch pads.
Note: the PID:VID for USB has been submitted to pidcodes but it's merge is pending the circuitpython merge.