Revert pull 5210, set DEBUG=1 gcc optimization flag to -Og for the RP2 port. #9925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Dec 29, 2024
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
If you verified it gets past early startup this seems fine to apply.
Collaborator
Author
|
@jepler Yes, starts up without issue. I've been using this patch for over a year on various RP2 boards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5210 changed the optimization flag for
DEBUG=1RP2 builds from-Ogto-O3to work around an ARM toolchain bug in CRT that caused a crash during C initialization. This bug is not present in at least ARM toolchain versions 12.3 and up. Since #9779 guarantees that the toolchain will be at least 13, it is safe to revert #5210.This change reverts to
-Ogwhich provides a superiorgdbdebugging experience compared to-O3.