Remove need for all-urls permission by using activeTab.#542
Open
dcoles wants to merge 2 commits intoadam-p:masterfrom
Open
Remove need for all-urls permission by using activeTab.#542dcoles wants to merge 2 commits intoadam-p:masterfrom
dcoles wants to merge 2 commits intoadam-p:masterfrom
Conversation
Using a content_type match against http://*/* and https://*/* grants the extension unfettered access to all data and all browsing activity on all sites. It also triggers a scary warning during installation. Using activeTab permission removes the need for continuous access to all sites by only injecting content scripts upon user interaction. To ensure that scripts aren't loaded multiple times, the `markdown_here_loaded` attribute is set on the document on first load.
|
dcoles's signed CLA |
|
+1 this PR, can we have it merged? that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a content_type match against
http://*/*andhttps://*/*grants theextension unfettered access to all data and all browsing activity on all
sites. It also triggers a scary warning during installation.
Using
activeTabpermission removes the need for continuous access to allsites by only injecting content scripts upon user interaction.
To ensure that scripts aren't loaded multiple times, the
markdown_here_loadedattribute is set on the document on first load.