Fix diff colours in docs #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cheers mate! Thank you for being so thorough! |
Contributor
Author
|
And thank you for django-upgrade! I ran it on python.org: python/pythondotorg#2820 |
Thanks, I just learned about accessible pygments 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#582 upgraded Furo, along with it's new accessible-pygments dependency (pradyunsg/furo@be0072d).
Unfortunately, accessible-pygments doesn't support the
diffcode block and is missing some CSS (Quansight-Labs/accessible-pygments#31), so diffs look like:https://django-upgrade.readthedocs.io/en/latest/fixers.html#django-4-2
Instead, set our own colours:
I've confirmed these all exceed the WCAG AA min ratio.