Skip to content

Feat/email destination changes#121

Merged
adammcdonagh merged 5 commits intomainfrom
feat/email-destination-changes
Jan 24, 2025
Merged

Feat/email destination changes#121
adammcdonagh merged 5 commits intomainfrom
feat/email-destination-changes

Conversation

@iwilson-oa
Copy link
Collaborator

  • Adjust email_destination TaskHandler to allow use of TLS/credentials to be optional, and set default port to 587
  • Adjust email_destination protocol schema to ensure that smtp_server and sender are set

@iwilson-oa iwilson-oa marked this pull request as ready for review January 24, 2025 15:31
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.25%. Comparing base (41358b1) to head (50577bb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/opentaskpy/remotehandlers/email.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   89.25%   89.25%   -0.01%     
==========================================
  Files          21       21              
  Lines        2486     2494       +8     
==========================================
+ Hits         2219     2226       +7     
- Misses        267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adammcdonagh adammcdonagh merged commit 8ca07f7 into main Jan 24, 2025
28 checks passed
@adammcdonagh adammcdonagh deleted the feat/email-destination-changes branch January 24, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants