patch linux older ue with CDN gitdeps.xml matching release#386
patch linux older ue with CDN gitdeps.xml matching release#386bradsaracik wants to merge 2 commits intoadamrehn:masterfrom
Conversation
| # See https://forums.unrealengine.com/t/upcoming-disruption-of-service-impacting-unreal-engine-users-on-github/1155880 | ||
| # In May 2023, Epics broke Commit.gitdeps.xml for *all existing releases up to 5.1.1* due to changes in their CDN | ||
| # we need to authenticate | ||
| password = os.getenv("GITPASS") |
There was a problem hiding this comment.
But where does GITPASS come from?
There was a problem hiding this comment.
passed in using that env from the dockerfile 02ad8f6#diff-ba195f13b5369f8c3e7b2e0e8d935ee5095b1863da01d742bbc5b5878b816218R90
https://docs.docker.com/build/building/secrets/#secret-mounts
There was a problem hiding this comment.
Yeah, but that won't work on Windows...
|
ahhh might need a documentation piece to make this work. (sorry picking up from too long ago already) |
unmerged PR #320 by @slonopotamus failed with authentication. This I think gets past it, but I only have run it on 4.27.2 under Linux (and in files using ubuntu24 to come in a separate PR)
Apologies this is only in Linux. maintainers allowed to edit
Black ran on file.
Note, this may also remove the need for https://github.com/adamrehn/ue4-docker/blob/master/test-suite/test-ue-releases.py#L28