Take a filename in find_missing_reqs as progress towards removing a bad monkeypatch

Author: adamtheturtle

pip_check_reqs/find_missing_reqs.py

@@ -19,7 +19,7 @@
 log = logging.getLogger(__name__)
 
 
-def find_missing_reqs(options):
+def find_missing_reqs(options, requirements_filename):
     # 1. find files used by imports in the code (as best we can without
     #    executing)
     used_modules = common.find_imported_modules(options)
@@ -58,10 +58,11 @@ def find_missing_reqs(options):
 
     # 4. compare with requirements.txt
     explicit = set()
-    for requirement in parse_requirements('requirements.txt',
-                                          session=PipSession()):
-        import pdb; pdb.set_trace()
-        log.debug('found requirement: %s', requirement.requirement)
+    for requirement in parse_requirements(
+        requirements_filename,
+        session=PipSession(),
+    ):
+        log.debug('found requirement: %s', requirement.name)
         explicit.add(canonicalize_name(requirement.name))
 
     return [(name, used[name]) for name in used if name not in explicit]
@@ -126,7 +127,11 @@ def main():
 
     log.info('using pip_check_reqs-%s from %s', __version__, __file__)
 
-    missing = find_missing_reqs(options)
+    requirements_filename = 'requirements.txt'
+    missing = find_missing_reqs(
+        options=options,
+        requirements_filename=requirements_filename,
+    )
 
     if missing:
         log.warning('Missing requirements:')

tests/test_find_missing_reqs.py

@@ -3,6 +3,7 @@
 import collections
 import logging
 import optparse
+from pathlib import Path
 
 import pytest
 import pretend
@@ -36,7 +37,7 @@ def parse_args(self):
     return FakeOptParse
 
 
-def test_find_missing_reqs(monkeypatch):
+def test_find_missing_reqs(monkeypatch, tmp_path: Path):
     imported_modules = dict(spam=common.FoundModule('spam',
                                                     'site-spam/spam.py',
                                                     [('ham.py', 1)]),
@@ -63,18 +64,15 @@ def test_find_missing_reqs(monkeypatch):
     monkeypatch.setattr(find_missing_reqs, 'search_packages_info',
                         pretend.call_recorder(lambda x: packages_info))
 
-    fake_requirements_file_contents = dedent(
-        """\
-        spam
-        """
-    )
-    FakeReq = collections.namedtuple('FakeReq', [])
-    requirements = [FakeReq()]
-    monkeypatch.setattr(
-        find_missing_reqs, 'parse_requirements',
-        pretend.call_recorder(lambda a, session=None: requirements))
+    fake_requirements_file = tmp_path / 'requirements.txt'
+    fake_requirements_file.write_text('spam')
 
-    result = list(find_missing_reqs.find_missing_reqs(None))
+    result = list(
+        find_missing_reqs.find_missing_reqs(
+            options=None,
+            requirements_filename=str(fake_requirements_file),
+        )
+    )
     assert result == [('shrub', [imported_modules['shrub']])]
 
 
@@ -83,10 +81,25 @@ def test_main_failure(monkeypatch, caplog, fake_opts):
 
     caplog.set_level(logging.WARN)
 
+    def fake_find_missing_reqs(options, requirements_filename):
+        return [
+            (
+                'missing',
+                [
+                    common.FoundModule(
+                        'missing',
+                        'missing.py',
+                        [('location.py', 1)],
+                    )
+                ]
+            )
+        ]
+
     monkeypatch.setattr(
-        find_missing_reqs, 'find_missing_reqs', lambda x: [('missing', [
-            common.FoundModule('missing', 'missing.py', [('location.py', 1)])
-        ])])
+        find_missing_reqs,
+        'find_missing_reqs',
+        fake_find_missing_reqs,
+    )
 
     with pytest.raises(SystemExit) as excinfo:
         find_missing_reqs.main()
@@ -144,7 +157,11 @@ def parse_args(self):
 
     monkeypatch.setattr(optparse, 'OptionParser', FakeOptParse)
 
-    monkeypatch.setattr(find_missing_reqs, 'find_missing_reqs', lambda x: [])
+    monkeypatch.setattr(
+        find_missing_reqs,
+        'find_missing_reqs',
+        lambda options, requirements_filename: [],
+    )
     find_missing_reqs.main()
 
     for event in [(logging.DEBUG, 'debug'), (logging.INFO, 'info'),