Fix SSH requirements crash #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itay-Saips
force-pushed
the
master
branch
2 times, most recently
from
7b75ce8 to
88176ca
Compare
| @@ -141,6 +142,12 @@ def find_required_modules(options, requirements_filename: str): | |||
| requirement.requirement, | |||
| ).name | |||
|
|
|||
| if requirement_name is None: | |||
| # This happens when the requirement parsing fails, for e.g. a | |||
There was a problem hiding this comment.
Does this only happen in this circumstance?
|
The branch in the patch is sound, but I don't like the fact that we are silently ignoring these requirements. IMO it should fail, unless e.g. a I'll be working on this soon. |
adamtheturtle
force-pushed
the
master
branch
from
f53f3f5 to
a7b797e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a requirement formatted as
git+ssh://[email protected]/...leads to a crash with the current code version - fixed this crash by ignoring these imports. Not a perfect solution, but better than searching for SSH keys on your machine and try to fetch repo IMO...