Item location relative to package, not 'here' #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, find_extra_reqs would concatenate the package_location with the file_location for a library import. This fails when using a virtualenv, because the package_location and the file_location end up sharing paths. This PR changes the file_location to be relative to the package, so that you get an actual file path. Fixes adamtheturtle#75.
|
Any update on this? It's a pretty low key change, would love to get this merged. |
|
I do not have availability right now to work on this. cc @MrMino . |
|
Some tests for this would be nice. I still need to reproduce the original issue to make sure this works. |
adamtheturtle
force-pushed
the
master
branch
from
f53f3f5 to
a7b797e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, find_extra_reqs would concatenate the package_location with the file_location for a library import. This fails when using a virtualenv, because the package_location and the file_location end up sharing paths. This PR changes the file_location to be relative to the package, so that you get an actual file path.
Fixes #75.