Skip to content

Update: Convert template to JSX (fix #357)#358

Open
swashbuck wants to merge 7 commits intomasterfrom
issue/357
Open

Update: Convert template to JSX (fix #357)#358
swashbuck wants to merge 7 commits intomasterfrom
issue/357

Conversation

@swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Feb 17, 2026

Fix #357

Update

  • Convert to template to JSX
  • Media player wrapped in React.memo to prevent re-renders (MEJS manages its own DOM)
  • Transcript toggle now model-driven (_isInlineTranscriptOpen) instead of jQuery DOM manipulation
  • Completion aria label moved from JS DOM injection (setTranscriptCompletionAria) into template
  • Removed events() method — click handlers passed as React onClick props

Fix

  • Replaced deprecated $(window).resize() with Adapt.trigger('device:resize')
  • Fixed media_poster → media__poster (BEM naming)
  • Fixed controls='controls' → controls (JSX boolean convention)

@swashbuck swashbuck marked this pull request as ready for review February 25, 2026 21:32
@swashbuck swashbuck changed the title Update: Convert to template to JSX (fix #357) Update: Convert template to JSX (fix #357) Feb 25, 2026
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Feb 25, 2026
@swashbuck
Copy link
Contributor Author

Ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Reviewing

Development

Successfully merging this pull request may close these issues.

Convert template from Handlebars to JSX

1 participant