chore(csharp): increase tracing granularity#150
Merged
birschick-bq merged 5 commits intoadbc-drivers:mainfrom Apr 1, 2026
Merged
Conversation
Collaborator
CurtHagenlocher
left a comment
There was a problem hiding this comment.
These changes mostly follow the pattern with the comma, but a few do concatenate instead. The comma looks wrong, but if it's right then maybe just explain the difference in a PR comment (unless you think it's worth explaining in a code comment).
Use nameof for method names in TraceActivity calls Replaced string literals with nameof(MethodName) in TraceActivity calls across BigQueryConnection.cs and BigQueryStatement.cs. This improves maintainability and reduces errors during refactoring by ensuring method names are always accurate in logs and traces.
…://github.com/birschick-bq/bigquery into dev/birschick-bq/increase-tracing-granularity
CurtHagenlocher
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed