Skip to content

chore(csharp): increase tracing granularity#150

Merged
birschick-bq merged 5 commits intoadbc-drivers:mainfrom
birschick-bq:dev/birschick-bq/increase-tracing-granularity
Apr 1, 2026
Merged

chore(csharp): increase tracing granularity#150
birschick-bq merged 5 commits intoadbc-drivers:mainfrom
birschick-bq:dev/birschick-bq/increase-tracing-granularity

Conversation

@birschick-bq
Copy link
Copy Markdown
Collaborator

@birschick-bq birschick-bq commented Mar 30, 2026

What's Changed

  • increases tracing granularity around most important steps in query execution.

@birschick-bq birschick-bq marked this pull request as draft March 31, 2026 00:07
@birschick-bq birschick-bq marked this pull request as ready for review March 31, 2026 18:26
Copy link
Copy Markdown
Collaborator

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes mostly follow the pattern with the comma, but a few do concatenate instead. The comma looks wrong, but if it's right then maybe just explain the difference in a PR comment (unless you think it's worth explaining in a code comment).

Use nameof for method names in TraceActivity calls

Replaced string literals with nameof(MethodName) in TraceActivity calls across BigQueryConnection.cs and BigQueryStatement.cs. This improves maintainability and reduces errors during refactoring by ensuring method names are always accurate in logs and traces.
@birschick-bq birschick-bq merged commit 2cd823e into adbc-drivers:main Apr 1, 2026
2 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/increase-tracing-granularity branch April 1, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants