Skip to content

feat(csharp): BigQueryPerformance changes#88

Merged
CurtHagenlocher merged 11 commits intoadbc-drivers:mainfrom
alokdeorani:bigqueryperformance
Jan 23, 2026
Merged

feat(csharp): BigQueryPerformance changes#88
CurtHagenlocher merged 11 commits intoadbc-drivers:mainfrom
alokdeorani:bigqueryperformance

Conversation

@alokdeorani
Copy link
Copy Markdown
Contributor

@alokdeorani alokdeorani commented Jan 9, 2026

This change focuses on performance and metadata handling.

Key changes include:

Metadata Query Support: The driver now supports standard
ADBC metadata retrieval functions. This allows you to query for catalogs (projects), schemas (datasets), tables, columns, and primary keys.
This is much faster than querying InformationSchema.

Automatic Large Query Handling: The driver now performs a "dry run" before executing a query. If it estimates that the query will process a large amount of data (over 120MB), it automatically enables settings to handle large results, improving performance and reliability for big queries.
New Configuration Parameters: Several new parameters have been added to control these new features, such as adbc.bigquery.include_public_project_id and parameters for metadata commands.
Testing Updates: The testing framework has been updated to validate the new metadata functionality.

@alokdeorani alokdeorani changed the title BigQueryPerformance changes feat: BigQueryPerformance changes Jan 12, 2026
@alokdeorani alokdeorani marked this pull request as ready for review January 13, 2026 18:17
Copilot AI review requested due to automatic review settings January 13, 2026 18:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Collaborator

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feedback left.

alokdeorani and others added 2 commits January 13, 2026 12:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Curt Hagenlocher <curt@hagenlocher.org>
@lidavidm lidavidm changed the title feat: BigQueryPerformance changes feat(csharp): BigQueryPerformance changes Jan 13, 2026
@CurtHagenlocher
Copy link
Copy Markdown
Collaborator

In principle, shouldn't BigQueryConnection.GetTableSchemas and BigQueryConnection.GetObjects also be changed to use the more efficient implementations instead of querying INFORMATION_SCHEMA? This could be filed as a followup work item.

Copy link
Copy Markdown
Collaborator

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My comments are mostly nitpicking, but we should probably think a little harder about returning the schema for nested structured data because it will be hard to fix this later without breaking existing uses.

Edit: there are also a few linter errors from the build.

Copy link
Copy Markdown
Collaborator

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good but the linter is still complaining. I think it's mostly about lines with trailing white space. One way to fix those in VS is to open the file and use Control-K Control-D to autoformat. (You can also do it manually of course.)

@alokdeorani
Copy link
Copy Markdown
Contributor Author

Thanks! The changes look good but the linter is still complaining. I think it's mostly about lines with trailing white space. One way to fix those in VS is to open the file and use Control-K Control-D to autoformat. (You can also do it manually of course.)

Thanks for the review, I did as suggested. I'm hoping it should be without errors now.

@CurtHagenlocher
Copy link
Copy Markdown
Collaborator

@alokdeorani, should I assume that you closed this PR by accident?

@alokdeorani
Copy link
Copy Markdown
Contributor Author

@alokdeorani, should I assume that you closed this PR by accident?

Yeah I think I did by mistake.

@CurtHagenlocher
Copy link
Copy Markdown
Collaborator

The linter is still failing :(. I think it's because my previous advice about autoformat doesn't work for trailing whitespace in comments. I guess autoformat probably doesn't touch comments.

@alokdeorani
Copy link
Copy Markdown
Contributor Author

The linter is still failing :(. I think it's because my previous advice about autoformat doesn't work for trailing whitespace in comments. I guess autoformat probably doesn't touch comments.

Checking

@alokdeorani
Copy link
Copy Markdown
Contributor Author

The linter is still failing :(. I think it's because my previous advice about autoformat doesn't work for trailing whitespace in comments. I guess autoformat probably doesn't touch comments.

Checking

I did some more fixes. I hope this time it will work.

@CurtHagenlocher
Copy link
Copy Markdown
Collaborator

I did some more fixes. I hope this time it will work.

Almost there! It looks like BigQueryStatement.cs either has an extra newline at the end or is missing a newline at the end.

@alokdeorani
Copy link
Copy Markdown
Contributor Author

I did some more fixes. I hope this time it will work.

Almost there! It looks like BigQueryStatement.cs either has an extra newline at the end or is missing a newline at the end.

Fixed it

@CurtHagenlocher CurtHagenlocher merged commit dc3ca18 into adbc-drivers:main Jan 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants