chore(csharp): update arrow-adbc submodule to point to hiveserver2#234
chore(csharp): update arrow-adbc submodule to point to hiveserver2#234eric-wang-1990 merged 8 commits intomainfrom
Conversation
Update the arrow-adbc submodule from apache/arrow-adbc to adbc-drivers/hiveserver2 repository. This change updates both the submodule URL and the commit reference to hiveserver2's main branch. The hiveserver2 repository includes the arrow-adbc code as a nested submodule, maintaining compatibility while pointing to the new upstream. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
🚀 Integration tests triggered! View workflow run |
|
Fixed the build failure by updating the project reference path to account for the nested submodule structure in hiveserver2's main branch. The issue was that hiveserver2's main branch has arrow-adbc as a nested submodule at Path change:
Build verified locally and CI should pass now. |
|
🔒 Integration test approval reset New commits were pushed to this PR. The A maintainer must re-review the changes and re-add the label to trigger tests again. Why is this necessary?
Latest commit: 8db13f2 |
Fix the path to Apache.Arrow.Adbc.Drivers.Apache.csproj to account for the nested submodule structure in hiveserver2's main branch. The path changed from: ..\arrow-adbc\csharp\src\Drivers\Apache\ To: ..\arrow-adbc\csharp\arrow-adbc\csharp\src\Drivers\Apache\ This is because hiveserver2's main branch has arrow-adbc as a nested submodule at csharp/arrow-adbc/ rather than having the source directly in the csharp/ directory. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
8db13f2 to
6af768b
Compare
…bcDrivers.HiveServer2 Update all namespace imports and project references to use AdbcDrivers.HiveServer2 instead of the nested Apache.Arrow.Adbc.Drivers.Apache structure. Changes: - Update project reference to AdbcDrivers.HiveServer2.csproj - Replace Apache.Arrow.Adbc.Drivers.Apache.* imports with AdbcDrivers.HiveServer2.* - Add AdbcDrivers.HiveServer2.Thrift namespace for SchemaParser - Remove duplicate using statements This aligns with the hiveserver2 repository structure where Spark, Hive2, and Impala drivers are unified in a single project. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Updated the PR to reference HiveServer2 project and migrated all namespaces: Changes:
This aligns with the hiveserver2 repository structure where Spark, Hive2, and Impala drivers are unified. |
- Update test project to reference nested arrow-adbc test dependencies - Reference AdbcDrivers.Tests.HiveServer2 instead of Apache test project - Update test file namespace imports to use HiveServer2 namespaces Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Update all test files to use AdbcDrivers.Tests.HiveServer2 namespaces: - AdbcDrivers.Tests.HiveServer2.Common - AdbcDrivers.Tests.HiveServer2.Spark - AdbcDrivers.Tests.HiveServer2 (for ApacheTestConfiguration) This aligns with the hiveserver2 test project structure. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fix the last remaining Apache namespace reference in DatabricksTestEnvironment.cs. All tests now build successfully with HiveServer2 namespaces. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Rename the submodule path from csharp/arrow-adbc to csharp/hiveserver2 to accurately reflect that it points to the hiveserver2 repository. Changes: - Renamed submodule path: csharp/arrow-adbc → csharp/hiveserver2 - Updated .gitmodules with new path and correct URL - Updated all project references to use new path - Initialized nested submodules (arrow-adbc and testing) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
🚀 Integration tests triggered! View workflow run |
…ocation mode Updates hiveserver2 submodule to commit edab9f8 which includes: - Configurable certificate revocation mode (PR #19) - Comprehensive TLS certificate validation error messages - Support for AWS PrivateLink and restricted network environments Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
🔒 Integration test approval reset New commits were pushed to this PR. The A maintainer must re-review the changes and re-add the label to trigger tests again. Why is this necessary?
Latest commit: d67dbf5 |
|
🚀 Integration tests triggered! View workflow run |
Summary
apache/arrow-adbctoadbc-drivers/hiveserver2Changes
.gitmodulesto point toadbc-drivers/hiveserver2.git514e13b57toedab9f8b8Apache.Arrow.Adbc.Drivers.ApachetoAdbcDrivers.HiveServer2New Features Included
The updated submodule (commit edab9f8) includes PR #19:
adbc.http_options.tls.revocation_mode(values: 0=NoCheck, 1=Online, 2=Offline)Structure
The new structure maintains compatibility through a nested submodule:
🤖 Generated with Claude Code