Skip to content

chore(csharp): update arrow-adbc submodule to point to hiveserver2#234

Merged
eric-wang-1990 merged 8 commits intomainfrom
update-submodule-to-hiveserver2
Feb 14, 2026
Merged

chore(csharp): update arrow-adbc submodule to point to hiveserver2#234
eric-wang-1990 merged 8 commits intomainfrom
update-submodule-to-hiveserver2

Conversation

@eric-wang-1990
Copy link
Collaborator

@eric-wang-1990 eric-wang-1990 commented Feb 12, 2026

Summary

Changes

  • Modified .gitmodules to point to adbc-drivers/hiveserver2.git
  • Updated submodule reference from commit 514e13b57 to edab9f8b8
  • Complete namespace migration from Apache.Arrow.Adbc.Drivers.Apache to AdbcDrivers.HiveServer2

New Features Included

The updated submodule (commit edab9f8) includes PR #19:

  • Configurable certificate revocation mode for TLS connections
    • New parameter: adbc.http_options.tls.revocation_mode (values: 0=NoCheck, 1=Online, 2=Offline)
    • Addresses certificate validation failures in restricted network environments (AWS PrivateLink, corporate firewalls)
  • Comprehensive TLS certificate validation error messages
    • Detailed, actionable error messages for common certificate validation failures
    • Helps diagnose issues like UntrustedRoot, PartialChain, RevocationStatusUnknown, etc.

Structure

The new structure maintains compatibility through a nested submodule:

databricks
└── csharp/hiveserver2 → hiveserver2 main (edab9f8)
    └── csharp/arrow-adbc → apache/arrow-adbc (nested)

🤖 Generated with Claude Code

Update the arrow-adbc submodule from apache/arrow-adbc to
adbc-drivers/hiveserver2 repository. This change updates both the
submodule URL and the commit reference to hiveserver2's main branch.

The hiveserver2 repository includes the arrow-adbc code as a nested
submodule, maintaining compatibility while pointing to the new upstream.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@eric-wang-1990 eric-wang-1990 added the integration-test Trigger integration tests in internal repo label Feb 12, 2026
@github-actions
Copy link

🚀 Integration tests triggered! View workflow run

@eric-wang-1990
Copy link
Collaborator Author

Fixed the build failure by updating the project reference path to account for the nested submodule structure in hiveserver2's main branch.

The issue was that hiveserver2's main branch has arrow-adbc as a nested submodule at csharp/arrow-adbc/, which adds an extra level in the path hierarchy compared to the previous structure where the source was directly in the csharp/ directory.

Path change:

  • Before: ..\arrow-adbc\csharp\src\Drivers\Apache
  • After: ..\arrow-adbc\csharp\arrow-adbc\csharp\src\Drivers\Apache

Build verified locally and CI should pass now.

@github-actions github-actions bot removed the integration-test Trigger integration tests in internal repo label Feb 12, 2026
@github-actions
Copy link

🔒 Integration test approval reset

New commits were pushed to this PR. The integration-test label has been automatically removed for security.

A maintainer must re-review the changes and re-add the label to trigger tests again.

Why is this necessary?
  • New code requires fresh security review
  • Prevents approved PRs from adding malicious code later
  • Ensures all tested code has been explicitly approved

Latest commit: 8db13f2

Fix the path to Apache.Arrow.Adbc.Drivers.Apache.csproj to account for
the nested submodule structure in hiveserver2's main branch.

The path changed from:
  ..\arrow-adbc\csharp\src\Drivers\Apache\

To:
  ..\arrow-adbc\csharp\arrow-adbc\csharp\src\Drivers\Apache\

This is because hiveserver2's main branch has arrow-adbc as a nested
submodule at csharp/arrow-adbc/ rather than having the source directly
in the csharp/ directory.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…bcDrivers.HiveServer2

Update all namespace imports and project references to use AdbcDrivers.HiveServer2
instead of the nested Apache.Arrow.Adbc.Drivers.Apache structure.

Changes:
- Update project reference to AdbcDrivers.HiveServer2.csproj
- Replace Apache.Arrow.Adbc.Drivers.Apache.* imports with AdbcDrivers.HiveServer2.*
- Add AdbcDrivers.HiveServer2.Thrift namespace for SchemaParser
- Remove duplicate using statements

This aligns with the hiveserver2 repository structure where Spark, Hive2,
and Impala drivers are unified in a single project.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@eric-wang-1990
Copy link
Collaborator Author

Updated the PR to reference HiveServer2 project and migrated all namespaces:

Changes:

  • ✅ Project reference: AdbcDrivers.HiveServer2.csproj (instead of nested Apache project)
  • ✅ Namespace migration: Apache.Arrow.Adbc.Drivers.Apache.*AdbcDrivers.HiveServer2.*
  • ✅ Added AdbcDrivers.HiveServer2.Thrift for SchemaParser access
  • ✅ Build verified locally

This aligns with the hiveserver2 repository structure where Spark, Hive2, and Impala drivers are unified.

- Update test project to reference nested arrow-adbc test dependencies
- Reference AdbcDrivers.Tests.HiveServer2 instead of Apache test project
- Update test file namespace imports to use HiveServer2 namespaces

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Update all test files to use AdbcDrivers.Tests.HiveServer2 namespaces:
- AdbcDrivers.Tests.HiveServer2.Common
- AdbcDrivers.Tests.HiveServer2.Spark
- AdbcDrivers.Tests.HiveServer2 (for ApacheTestConfiguration)

This aligns with the hiveserver2 test project structure.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fix the last remaining Apache namespace reference in DatabricksTestEnvironment.cs.

All tests now build successfully with HiveServer2 namespaces.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Rename the submodule path from csharp/arrow-adbc to csharp/hiveserver2
to accurately reflect that it points to the hiveserver2 repository.

Changes:
- Renamed submodule path: csharp/arrow-adbc → csharp/hiveserver2
- Updated .gitmodules with new path and correct URL
- Updated all project references to use new path
- Initialized nested submodules (arrow-adbc and testing)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@eric-wang-1990 eric-wang-1990 added the integration-test Trigger integration tests in internal repo label Feb 12, 2026
@eric-wang-1990 eric-wang-1990 requested review from birschick-bq and davidhcoe and removed request for birschick-bq February 12, 2026 09:11
@github-actions
Copy link

🚀 Integration tests triggered! View workflow run

…ocation mode

Updates hiveserver2 submodule to commit edab9f8 which includes:
- Configurable certificate revocation mode (PR #19)
- Comprehensive TLS certificate validation error messages
- Support for AWS PrivateLink and restricted network environments

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions github-actions bot removed the integration-test Trigger integration tests in internal repo label Feb 12, 2026
@github-actions
Copy link

🔒 Integration test approval reset

New commits were pushed to this PR. The integration-test label has been automatically removed for security.

A maintainer must re-review the changes and re-add the label to trigger tests again.

Why is this necessary?
  • New code requires fresh security review
  • Prevents approved PRs from adding malicious code later
  • Ensures all tested code has been explicitly approved

Latest commit: d67dbf5

@eric-wang-1990 eric-wang-1990 added the integration-test Trigger integration tests in internal repo label Feb 12, 2026
@github-actions
Copy link

🚀 Integration tests triggered! View workflow run

@eric-wang-1990 eric-wang-1990 added this pull request to the merge queue Feb 14, 2026
Merged via the queue into main with commit 4780d28 Feb 14, 2026
32 checks passed
@eric-wang-1990 eric-wang-1990 deleted the update-submodule-to-hiveserver2 branch February 14, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-test Trigger integration tests in internal repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants