feat(go): add databricks:// uri support, tests, and docs#102
Merged
lidavidm merged 3 commits intoadbc-drivers:mainfrom Dec 29, 2025
Merged
feat(go): add databricks:// uri support, tests, and docs#102lidavidm merged 3 commits intoadbc-drivers:mainfrom
lidavidm merged 3 commits intoadbc-drivers:mainfrom
Conversation
lidavidm
approved these changes
Dec 29, 2025
go/docs/databricks.md
Outdated
|
|
||
| Components: | ||
| - `scheme`: `databricks://` (required) | ||
| - `<personal-access-token>`: (required) Databricks personal access token from the requirements. |
Contributor
There was a problem hiding this comment.
What is "from the requirements" referring to?
Collaborator
Author
There was a problem hiding this comment.
The Databricks documentation linked below has the requirements section, and it is referring to that, but it is probably cleaner without referring to it. I removed it.
lidavidm
reviewed
Dec 29, 2025
Comment on lines
+337
to
+338
| if after, ok := strings.CutPrefix(value, "databricks://"); ok { | ||
| d.uri = after |
Contributor
There was a problem hiding this comment.
Actually...do we need to also URL-decode the string? Or does the Databricks driver do that?
Collaborator
Author
There was a problem hiding this comment.
We do not need to URL-decode the string, the Databricks driver handles it.
https://github.com/databricks/databricks-sql-go/blob/main/internal/config/config.go#L210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Support databricks:// URI scheme
Basic connection test with URI
Document URI formats