feat(csharp): implement Statement.SetOption for adbc.telemetry.trace_parent#130
Closed
birschick-bq wants to merge 1 commit intoadbc-drivers:mainfrom
Closed
Conversation
birschick-bq
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Collaborator
eric-wang-1990
left a comment
eric-wang-1990
left a comment
There was a problem hiding this comment.
Hi @birschick-bq I open this PR to allow override traceParent on the TracingStatement, I thought it would be a little more cleaner? https://github.com/apache/arrow-adbc/pull/3896/files#diff-ea22827c908183e8cae28e5fcc37cef9d0c4b5637474262cffe163b6b78db9f5
| } | ||
| break; | ||
| case AdbcOptions.Telemetry.TraceParent: | ||
| ((IActivityTracer)this).Trace.TraceParent = string.IsNullOrWhiteSpace(value) ? null : value; |
Collaborator
There was a problem hiding this comment.
Why set to null if non-exist? Should it set to the existing traceParent for connection?
Collaborator
Author
There was a problem hiding this comment.
I think callers will need to remember to set the TraceParent on the Connection, as well.
Collaborator
Author
|
Abandoning this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Closes #129.