Skip to content

fix(ci): remove paths filter from e2e-tests pull_request trigger#354

Merged
eric-wang-1990 merged 1 commit intomainfrom
e-wang_data/fix/e2e-workflow-pr-trigger
Mar 17, 2026
Merged

fix(ci): remove paths filter from e2e-tests pull_request trigger#354
eric-wang-1990 merged 1 commit intomainfrom
e-wang_data/fix/e2e-workflow-pr-trigger

Conversation

@eric-wang-1990
Copy link
Collaborator

Summary

The run-e2e-tests required status check was stuck as "Waiting for status to be reported" on PRs that don't touch csharp/ files (e.g. docs-only or rust-only PRs). The root cause: e2e-tests.yml had a paths: filter on the pull_request trigger, so the workflow never fired and the gate step never got to post the auto-pass check.

Fix: remove paths: from the pull_request trigger. Path-based gating is already handled correctly:

  • PR events → gate step auto-passes (no tests run)
  • Merge queue → gate step runs git diff and skips if no csharp files changed

This aligns e2e-tests.yml with trigger-integration-tests.yml, which has no paths: filter for the same reason.

Test plan

  • Verify run-e2e-tests posts auto-pass on a docs/rust-only PR
  • Verify run-e2e-tests still runs in merge queue when csharp files changed
  • Verify run-e2e-tests skips in merge queue when no csharp files changed

🤖 Generated with Claude Code

The paths: filter prevented the workflow from firing on non-csharp PRs,
leaving the required run-e2e-tests check stuck as "Waiting for status to
be reported". The gate step already handles path-based skipping for both
PR (auto-pass) and merge_group (git diff check), so the trigger-level
filter is redundant and harmful.

Aligns with trigger-integration-tests.yml which has no paths filter.

Co-authored-by: Eric Wang <e.wang@databricks.com>
Copy link
Collaborator

@msrathore-db msrathore-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eric-wang-1990 eric-wang-1990 added this pull request to the merge queue Mar 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2026
@eric-wang-1990 eric-wang-1990 added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit fe7618f Mar 17, 2026
10 checks passed
@eric-wang-1990 eric-wang-1990 deleted the e-wang_data/fix/e2e-workflow-pr-trigger branch March 17, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants