Skip to content

fix(csharp): disable feature flag cache by default#358

Merged
jadewang-db merged 3 commits intomainfrom
stack/disable-config-cache
Mar 19, 2026
Merged

fix(csharp): disable feature flag cache by default#358
jadewang-db merged 3 commits intomainfrom
stack/disable-config-cache

Conversation

@jadewang-db
Copy link
Collaborator

@jadewang-db jadewang-db commented Mar 18, 2026

🥞 Stacked PR

Use this link to review incremental changes.


What's Changed

Please fill in a description of the changes here.

This contains breaking changes.

Closes #NNN.

@jadewang-db
Copy link
Collaborator Author

Range-diff: main (2a32530 -> 24eb3ef)
csharp/src/Telemetry/TelemetryConfiguration.cs
@@ -0,0 +1,14 @@
+diff --git a/csharp/src/Telemetry/TelemetryConfiguration.cs b/csharp/src/Telemetry/TelemetryConfiguration.cs
+--- a/csharp/src/Telemetry/TelemetryConfiguration.cs
++++ b/csharp/src/Telemetry/TelemetryConfiguration.cs
+ 
+         /// <summary>
+         /// Gets or sets whether telemetry is enabled.
+-        /// Default is true.
++        /// Default is false.
+         /// </summary>
+-        public bool Enabled { get; set; } = true;
++        public bool Enabled { get; set; } = false;
+ 
+         /// <summary>
+         /// Gets or sets the batch size for telemetry metrics.
\ No newline at end of file

Reproduce locally: git range-diff d4083ce..2a32530 d4083ce..24eb3ef | Disable: git config gitstack.push-range-diff false

@jadewang-db jadewang-db changed the title change feature flag cache to default false fix(csharp): disable feature flag cache by default Mar 19, 2026
@jadewang-db jadewang-db added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
…re flag cache

Tests were asserting the old defaults (enabled=true). Updated telemetry
config tests to expect Enabled=false and feature flag cache E2E tests to
explicitly enable the cache since it's now opt-in.

Co-authored-by: Isaac
@jadewang-db jadewang-db enabled auto-merge March 19, 2026 18:40
@jadewang-db jadewang-db added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
@jadewang-db jadewang-db added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 140868b Mar 19, 2026
16 checks passed
@jadewang-db jadewang-db deleted the stack/disable-config-cache branch March 19, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants