Skip to content

Conversation

@msrathore-db
Copy link
Collaborator

@msrathore-db msrathore-db commented Nov 17, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Summary

Adds FileDownloadMetrics class for tracking per-file download performance metrics. Foundation for identifying slow downloads (stragglers).

Key Changes:

  • FileDownloadMetrics class implementation
    • Tracks file offset, size, start/completion time
    • Calculates throughput in bytes/second
    • Manages straggler cancellation flag
    • Thread-safe state management
  • ✅ Unit tests for throughput calculation and flag management
    • Verify null throughput for in-progress downloads
    • Verify positive throughput for completed downloads
    • Test straggler flag setting

- Implement FileDownloadMetrics class to track per-file download metrics
- Track start time, completion time, and throughput calculation
- Add straggler cancellation flag
- Thread-safe state management
- Add unit tests for throughput calculation and flag management

Builds on: stack/straggler-config-foundation
/// </summary>
/// <param name="fileOffset">The file offset in the download batch.</param>
/// <param name="fileSizeBytes">The size of the file in bytes.</param>
public FileDownloadMetrics(long fileOffset, long fileSizeBytes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this works with SEA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants