Skip to content

Conversation

@lidavidm
Copy link
Contributor

@lidavidm lidavidm commented Nov 11, 2025

What's Changed

  • Generate test/release workflows with separated permissions
  • Generate dev workflow
  • Generate pull_request_trigger dev workflow
  • Generate issue assignment bot
  • Update the action versions semi-automatically
  • Trigger the test workflow when it itself is updated
  • Make this easier to run on a repo

For future enhancement:

  • Generate issue templates
  • Add unit tests

@lidavidm lidavidm marked this pull request as draft November 11, 2025 01:19
@lidavidm lidavidm force-pushed the dev branch 2 times, most recently from d4266ef to b1135d5 Compare December 12, 2025 17:41
@lidavidm lidavidm marked this pull request as ready for review December 15, 2025 16:54
@lidavidm lidavidm requested a review from amoeba December 15, 2025 16:55
Copy link
Contributor

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty reasonable. Did you consider using a repo template instead? Since we always have to set up a new repo I don't the repo template approach makes as much sense as it otherwise does.

Edit: I kept reading and I see how you did things makes really good sense and that the repo template approach would make less sense.

undefined=jinja2.StrictUndefined,
)

config_path = args.repository / ".github/workflows/generate.toml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would be something we'd set up beforehand?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and I had to at least specify this in my generate.toml to get the generate subcommand to run,

private = true
environment = "foo"
permissions = {"id_token" = "some_tok"}
driver = "somedriver"
lang = {"go"=true}

can we make the minimum required even simpler? driver and lang could be required, maybe private as well. But the others could maybe be made optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yeah, I've only tested on one repo so I'll go test it with some other things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I could have it generate a basic toml under a different command too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - it'll generate generate.toml if it's not found and it's nicer about defaults now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds great.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and this works nicely.

@lidavidm
Copy link
Contributor Author

Yeah I didn't even consider repo templates. My model for this is conda-smithy for conda-forge

@lidavidm lidavidm merged commit 8b15f64 into main Dec 15, 2025
3 checks passed
@lidavidm lidavidm deleted the dev branch December 15, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants