Singleton code example simplification#176
Open
svenheden wants to merge 1 commit intoaddyosmani:masterfrom
svenheden:singleton-demo
Open
Singleton code example simplification#176svenheden wants to merge 1 commit intoaddyosmani:masterfrom svenheden:singleton-demo
svenheden wants to merge 1 commit intoaddyosmani:masterfrom
svenheden:singleton-demo
Conversation
…stead of random numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the singleton code example by comparing object references instead of random numbers.
This is just a proposal, I'm not 100% sure this makes the code example more clear, but maybe. :)
I think it shows the intent of the comparison in the end more, and the random number disclaimer is no longer needed.