Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes full-screen editor layout so the toolbar behavior matches the intended scroll interaction.
- Makes MarkdownTextInput’s layout flexible by wrapping TextFormField with Flexible and setting Column’s mainAxisSize to min.
- Removes the outer SizedBox and SingleChildScrollView in full view, embedding MarkdownTextInput directly in AnimatedSwitcher.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/widgets/MarkdownTextInput/markdown_text_input.dart | Adjusts the internal layout: adds mainAxisSize: MainAxisSize.min and wraps the TextFormField with Flexible. |
| lib/home.dart | Simplifies full-screen view: removes explicit sizing and SingleChildScrollView, uses MarkdownTextInput directly. |
Comments suppressed due to low confidence (2)
lib/home.dart:1
- Removing the SingleChildScrollView here makes the full-screen editor non-scrollable as a whole; only the TextFormField scrolls internally, leaving the toolbar fixed on screen rather than scrolling away with the editor. To have the toolbar scroll along with the content, wrap the MarkdownTextInput with a SingleChildScrollView (or move that scroll container inside MarkdownTextInput so it wraps the entire Column). For example: child: _isPreview ? _markdownPreviewWidget() : SingleChildScrollView(child: MarkdownTextInput(...)).
import 'dart:convert';
lib/widgets/MarkdownTextInput/markdown_text_input.dart:1
- Using Flexible inside a Column with mainAxisSize: MainAxisSize.min can leave the Flexible child with zero available height, leading to a collapsed or poorly sized TextFormField in typical bounded layouts. Prefer making the Column take available space and let the field expand: set mainAxisSize to MainAxisSize.max (or remove the property to use the default) and use Expanded for the field, e.g., mainAxisSize: MainAxisSize.max and Expanded(child: TextFormField(...)).
import 'package:expandable/expandable.dart';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Fixes the full-screen editor having toolbar on top instead of being scrolled away with it