Skip to content

🐛 fixes #19#27

Merged
adeeteya merged 1 commit intomasterfrom
full_screen_editor_fixes
Oct 5, 2025
Merged

🐛 fixes #19#27
adeeteya merged 1 commit intomasterfrom
full_screen_editor_fixes

Conversation

@adeeteya
Copy link
Owner

@adeeteya adeeteya commented Oct 5, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission work for all the platforms?
  2. Have you lint your code locally before submission? (using flutter_lints package)

Fixes the full-screen editor having toolbar on top instead of being scrolled away with it

@adeeteya adeeteya requested a review from Copilot October 5, 2025 11:53
@adeeteya adeeteya merged commit 45fdb9e into master Oct 5, 2025
1 check passed
@adeeteya adeeteya deleted the full_screen_editor_fixes branch October 5, 2025 11:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes full-screen editor layout so the toolbar behavior matches the intended scroll interaction.

  • Makes MarkdownTextInput’s layout flexible by wrapping TextFormField with Flexible and setting Column’s mainAxisSize to min.
  • Removes the outer SizedBox and SingleChildScrollView in full view, embedding MarkdownTextInput directly in AnimatedSwitcher.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/widgets/MarkdownTextInput/markdown_text_input.dart Adjusts the internal layout: adds mainAxisSize: MainAxisSize.min and wraps the TextFormField with Flexible.
lib/home.dart Simplifies full-screen view: removes explicit sizing and SingleChildScrollView, uses MarkdownTextInput directly.
Comments suppressed due to low confidence (2)

lib/home.dart:1

  • Removing the SingleChildScrollView here makes the full-screen editor non-scrollable as a whole; only the TextFormField scrolls internally, leaving the toolbar fixed on screen rather than scrolling away with the editor. To have the toolbar scroll along with the content, wrap the MarkdownTextInput with a SingleChildScrollView (or move that scroll container inside MarkdownTextInput so it wraps the entire Column). For example: child: _isPreview ? _markdownPreviewWidget() : SingleChildScrollView(child: MarkdownTextInput(...)).
import 'dart:convert';

lib/widgets/MarkdownTextInput/markdown_text_input.dart:1

  • Using Flexible inside a Column with mainAxisSize: MainAxisSize.min can leave the Flexible child with zero available height, leading to a collapsed or poorly sized TextFormField in typical bounded layouts. Prefer making the Column take available space and let the field expand: set mainAxisSize to MainAxisSize.max (or remove the property to use the default) and use Expanded for the field, e.g., mainAxisSize: MainAxisSize.max and Expanded(child: TextFormField(...)).
import 'package:expandable/expandable.dart';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants