Add status files in /var/run/hd-idle #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @DocMAX |
Author
|
I allready wrote in the PR what this change does. |
Owner
Updating the documentation is a way to enable other users to understand how to use the new feature. |
added 4 commits
August 31, 2025 07:56
…testing disk filesystem types
Introduces a new configuration option, `SkipIfMounted`, to prevent hard drives from spinning down if they are currently mounted. This feature can be enabled globally or per-device. - Add `SkipIfMounted` boolean to `DefaultConf` and `DeviceConf`. - Implement `isDeviceMounted` function using `findmnt` to check mount status. - Modify `updateState` to check `SkipIfMounted` before initiating spindown. - Add `-M` command-line flag to enable this behavior. - Update usage instructions to reflect the new option. This prevents potential data corruption or issues that could arise from spinning down an actively used, mounted drive.
Introduce a `--dry-run` CLI flag to simulate disk spindown operations without executing actual commands, allowing for safe testing of configurations. Improve the `isDeviceMounted` function to reliably detect mounted devices, including Btrfs and ZFS filesystems, and to check for mounted partitions. This makes the `skip-if-mounted` feature more accurate and robust.
Add a new `verbose` flag (`-v`, `--verbose`) to provide more user-facing informational output. This flag is distinct from the `debug` flag, which is intended for more internal debugging details. Update various print statements to be conditional on `verbose` (or `debug` or `logFile` presence) for events like disk spindown/spinup, and reasons for skipping spindown (e.g., device mounted). Enhance messages for Btrfs and ZFS devices when spindown is skipped due to being mounted. Remove the `LastSpunDownAt` field from the detailed disk state debug output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a summary of the changes made to hd-idle:
Added creation of /var/run/hd-idle directory at startup
Added writing "0" to /var/run/hd-idle/sdX.status when a disk spins down
Added writing "1" to /var/run/hd-idle/sdX.status when a disk spins up
Error handling for file operations (only logged in debug mode)
The changes maintain all existing functionality while adding the requested status file feature. The status files will be created with:
Content "1" when the disk spins up
Content "0" when the disk spins down
File permissions 0644 (readable by all users)
The implementation is robust and handles cases where:
The directory doesn't exist (it will be created)
File writes fail (errors are logged in debug mode)
Multiple disks are being monitored (each gets its own status file)