feat(a11y): add accessibility labels to top menu and tabs#129
feat(a11y): add accessibility labels to top menu and tabs#129abouhoraira2006 wants to merge 5 commits intoadelpro:developfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
adelpro
left a comment
adelpro
left a comment
There was a problem hiding this comment.
Please do not change any code outside the parts related to the issue.
| }; | ||
|
|
||
| export function TopTabs({ activeTab, setActiveTab }: Props) { | ||
| export default function TopTabs({ activeTab, setActiveTab }: Props) { |
There was a problem hiding this comment.
Please do not change the function export
| import { StyleSheet, TouchableOpacity } from 'react-native'; | ||
|
|
||
| import { useColors } from '@/hooks'; | ||
| import { useColors } from '@/hooks/useColors'; |
There was a problem hiding this comment.
Please keep the import structure as it
|
Salam @abouhoraira2006 |
|
مرحباً أخي @adelpro، لقد قمت بالتراجع عن التعديلات الجانبية في ملف أعتقد أن الكود الآن جاهز للمراجعة النهائية والدمج. شكراً لوقتك! 🌙 |
adelpro
left a comment
adelpro
left a comment
There was a problem hiding this comment.
Please chech these minor issues
Salam @abouhoraira2006, |
|
هلا @adelpro، خلاص ظبطت كل مشاكل التنسيق (Linting) ورجعت الاستيرادات في ملف TopMenu زي ما كانت بالضبط. يعطيك العافية , تقبل الله صيامك |
adelpro
left a comment
adelpro
left a comment
There was a problem hiding this comment.
Please remove all the import changes
|
Hey @adelpro, I've reverted all the import changes as requested. Does everything look good to go now? |
The import changes are still present. Could you please double-check and remove them? |
2 participants
Description
This PR enhances the accessibility (TalkBack support) for the main interactive UI components in
TopMenuandTopTabs. Added properaccessibilityRole,accessibilityLabel,accessibilityHint, andaccessibilityStateto ensure visually impaired users can navigate the app smoothly.Part of the Ramadan Al-Athar initiative (رمضان الأثر). 🌙
Related Issue
Closes #124
Testing