Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cakerug
commented
Dec 16, 2024
| if (transform.mode === 'ts-implicit') { | ||
| const transformer = new TypedSqlTagTransformer(pool, config, transform); | ||
| return transformer.start(isWatchMode); | ||
| return transformer.start(isWatchMode, fileOverride); |
Author
There was a problem hiding this comment.
Tested this and this change actually breaks b/c this transformer doesn't support fileOverride.
Also, we should make the globSync take absolute: true because right now it confusingly matches against the {srcDir}/file/path/filename.sql. And update the --help.
Anyway, since there seems like there isn't really movement on these PRs, going to abandon this and maybe someone can pick it up if things change with the project.
| transform, | ||
| ); | ||
| return transformer.start(isWatchMode); | ||
| return transformer.start(isWatchMode, fileOverride); |
Author
There was a problem hiding this comment.
this path works and was what I tested previously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #579