fix: escape special characters in enum values#635
Open
debroys wants to merge 1 commit intoadelsz:masterfrom
Open
fix: escape special characters in enum values#635debroys wants to merge 1 commit intoadelsz:masterfrom
debroys wants to merge 1 commit intoadelsz:masterfrom
Conversation
Fixes adelsz#611 - enum values containing apostrophes or backslashes now generate valid TypeScript. Added escapeEnumValue() function that escapes backslashes and single quotes in enum values before wrapping them in string literals.
|
Someone is attempting to deploy a commit to the Adel Salakh's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #611
When PostgreSQL enum values contain apostrophes (e.g.,
car's), pgtyped generates invalid TypeScript:Added escapeEnumValue() function that escapes backslashes and single quotes before wrapping enum values in string literals:
car's→'car\'s'path\dir→'path\\dir'Added 3 unit tests in packages/cli/src/generator.test.ts covering: